[Webkit-unassigned] [Bug 95578] [WK2][WTR] CodeGeneratorTestRunner should support web idl overloading functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95578





--- Comment #9 from Jussi Kukkonen (jku) <jussi.kukkonen at intel.com>  2012-12-14 03:02:51 PST ---
(In reply to comment #8)
> > This might not be worth it if it would only be used in a few tests, and there are no other overloaded IDL functions we need...
> 
> Can you please quantify "a few tests"?

I have not checked each preference yet. I can tell that only three tests use overrridePreference() with a value other than [true, false, 0, 1, "0", "1"]:

LayoutTests/fast/harness/override-preferences-2.html:
    testRunner.overridePreference("WebKitDefaultFontSize", "24")
LayoutTests/fast/harness/override-preferences-2.html:
    testRunner.overridePreference("WebKitMinimumFontSize", "12");
LayoutTests/http/tests/download/default-encoding.html:
    testRunner.overridePreference("WebKitDefaultTextEncodingName", "koi8-r");


Btw, as I was checking things I realized that we have 99 webgl tests in wk2/TestExpectations with this comment:
 # WebKit2 needs layoutTestController.overridePreference
 # <https://bugs.webkit.org/show_bug.cgi?id=42197>
My understanding was that boolean preferences already work and it looks like these tests only use a boolean override... I run the tests and 82/99 tests pass on wk2-efl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.