[Webkit-unassigned] [Bug 104970] Web Inspector: Search by selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104970





--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-12-14 00:08:40 PST ---
(From update of attachment 179365)
View in context: https://bugs.webkit.org/attachment.cgi?id=179365&action=review

Looks good, style nits inline.

> Source/WebCore/inspector/front-end/AdvancedSearchController.js:246
> +    syncToSelection: function()

Rename to _syncToSelection (make private)

> Source/WebCore/inspector/front-end/AdvancedSearchController.js:249
> +        if (selection.type === "Range" && !selection.isCollapsed)

We typically do if (selection.rangeCount)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.