[Webkit-unassigned] [Bug 104835] Web Inspector: Don't throw exceptions in WebInspector.Color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104835


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179110|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-12-14 00:02:21 PST ---
(From update of attachment 179110)
View in context: https://bugs.webkit.org/attachment.cgi?id=179110&action=review

Looks good. Small style nit and annotation.

> Source/WebCore/inspector/front-end/Color.js:36
> +    this.valid = this._parse();

I'd rather introduce wrapper WebInspector.Color.parse(str) that would return nullable Color. You can still leave _parse in place and make "valid" private then. You'll simply return null when !color._valid.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.