[Webkit-unassigned] [Bug 101904] [EFL][WK2] Add API to execute js script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101904





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-13 23:56:53 PST ---
(From update of attachment 173587)
View in context: https://bugs.webkit.org/attachment.cgi?id=173587&action=review

>>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:926
>>> +struct _Ewk_View_Script_Execute_Callback_Context {
>> 
>> I think ewk_view_private.h or EwkViewImpl.h is more better place for this struct.
> 
> Why? if this struct is used only in ewk_view.cpp, then I think this is the right place for it. However, we don't use _ prefix for such structures anymore.

If so, what do you think ewk_view_private.h role ? Do you think it isn't for internal data type or struct ?

>>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:943
>>> +    JSGlobalContextRef jsGlobalContext = impl->ewkContext()->jsGlobalContext();
>> 
>> Don't you need to free jsGlobalContext using JSGlobalContextRelease() after finishing to use it ?
> 
> Looks like the global context object is owned by Ewk_Context so I don't think we should free it here.

Ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.