[Webkit-unassigned] [Bug 104985] Seconds/Minutes field of date/time input UI should respect step attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104985





--- Comment #2 from Kent Tamura <tkent at chromium.org>  2012-12-13 19:35:29 PST ---
(From update of attachment 179402)
View in context: https://bugs.webkit.org/attachment.cgi?id=179402&action=review

The logic looks good. I have one comment.

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:155
> +        int step, stepBase;
> +        getFieldStep(static_cast<int>(msPerMinute), static_cast<int>(msPerHour), step, stepBase);
> +        RefPtr<DateTimeNumericFieldElement> field = DateTimeMinuteFieldElement::create(document, m_editElement, step, stepBase);
>          m_editElement.addField(field);

I'd like to recommend to introduce DateTimeNumericFieldElement::Parameters, which contains step and stepBase.  If so, getFieldStep would be "DateTimeNumericFieldElement::Parameters createNumericFieldParameters(const Decimal&, const Decima&)", and field constructors would receive "const DateTimeNumericFieldElement::Parameters&".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.