[Webkit-unassigned] [Bug 104631] Emphasis mark is printed after inline-block with justify

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104631





--- Comment #7 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2012-12-13 18:42:23 PST ---
(In reply to comment #5)

Thank you for reviewing.

> > Source/WebCore/ChangeLog:8
> > +        Fix emphasis mark is printed after inline-block with justify.
> 
> -> "Do not print an emphasis mark after an inline-block when justified."

Fixed.

> > Source/WebCore/ChangeLog:14
> > +        If an inline-block is expanded, a space is added after inline-block.
> > +        Emphasis mark is drawn over the space for the expand.
> > +
> > +        When an emphasis mark is drawn, check the charactor is the space.
> > +        If so, don't draw emphasis mark.
> 
> -> "If an inline-block is expanded, it has a space appended to it. This space should not have any emphasis marks drawn."

Fixed.

> > Source/WebCore/platform/graphics/WidthIterator.cpp:228
> > +                                    glyphBuffer->add(0, fontData, m_expansionPerOpportunity);
> 
> I wonder if we should have a special name for a null glyph, or a glyph we don't care about?

I think zero width space is better than a null glyph.
Therefore, I change the fix to use zero width space glyph.

> > LayoutTests/ChangeLog:8
> > +        Test that draw emphasis mark to justified inline box and text.
> 
> -> Test that emphasis marks are not drawn incorrectly in justified text with inline boxes.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.