[Webkit-unassigned] [Bug 104191] Implement matching cue by the class name with ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104191


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178938|review?                     |review-
               Flag|                            |




--- Comment #24 from Antti Koivisto <koivisto at iki.fi>  2012-12-13 18:07:17 PST ---
(From update of attachment 178938)
View in context: https://bugs.webkit.org/attachment.cgi?id=178938&action=review

Looks good otherwise.

> Source/WebCore/html/track/TextTrackCue.cpp:494
> +    for (Node* child = root->firstChild(); child; child = NodeTraversal::next(child, root))
> +        static_cast<Element*>(child)->setIsWebVTTNode(true);

This is still unsafe case. If someone adds a non Element (like Text) to the WebVTT tree you will have memory corruption. At minimum you should use toElement() casting function which includes assert. But really using the new ElementTraversal interface is the way to go.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.