[Webkit-unassigned] [Bug 104279] [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 09:03:44 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104279





--- Comment #8 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2012-12-13 09:06:06 PST ---
(From update of attachment 178047)
View in context: https://bugs.webkit.org/attachment.cgi?id=178047&action=review

> Tools/Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb:44
> +  output = sanitized_output %x{ #{$tool} #{config[:paths].join(' ')} 2>&1 }
> +  expected_output = File.read File.join($test_directory, config[:expected])
> +  pass = output == expected_output

Also, if the test passes, I think the *-expected.txt file should have the word "PASS" with a newline in it (rather than just being blank).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list