[Webkit-unassigned] [Bug 104830] Document is never released when an Image is created inside unload event listener.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104830


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179112|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2012-12-12 19:55:09 PST ---
(From update of attachment 179112)
View in context: https://bugs.webkit.org/attachment.cgi?id=179112&action=review

> Source/WebCore/loader/ImageLoader.cpp:203
> +        Frame* frame = document()->frame();
> +        bool pageIsBeingDismissed = frame && frame->loader()->pageDismissalEventBeingDispatched() != FrameLoader::NoDismissal;

It seems wasteful to do all this computation when newImage is non-zero. Could you put this into a helper function so it’s only computed when newImage is 0?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.