[Webkit-unassigned] [Bug 104628] Milliseconds field of date/time input UI should respect step attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 18:13:14 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104628





--- Comment #8 from Kunihiko Sakamoto <ksakamoto at chromium.org>  2012-12-12 18:15:36 PST ---
(From update of attachment 178961)
View in context: https://bugs.webkit.org/attachment.cgi?id=178961&action=review

>> Source/WebCore/ChangeLog:11
>> +        Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
> 
> You need to add tests for
>   step=0
>   step=0.00001

Done.

>> Source/WebCore/html/shadow/DateTimeEditElement.cpp:221
>> +        if (decimalMsPerSecond.remainder(m_parameters.stepRange.step()).isZero()) {
> 
> You need to check m_parameters.stepRange.step().remainder(Decimal(1)).isZero() too.

Done.

>> Source/WebCore/html/shadow/DateTimeEditElement.cpp:223
>> +            stepBase = static_cast<int>(m_parameters.stepRange.stepBase().remainder(decimalMsPerSecond).toDouble());
> 
> Why don't you subtract msPerSecond from the remainder result and assume stepBase<=0 ?  It would make roundUp/roundDown simpler.

But roundDown still has to handle n=-1 when stepped down from zero.
I'd prefer to keep roundUp/roundDown capable of handling general cases.

>> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:82
>> +
> 
> We should test rounding of defaultValeuForStepDown/Up.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list