[Webkit-unassigned] [Bug 92818] REGRESSION: WebKit does not render selection in non-first ruby text nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92818





--- Comment #12 from Elliott Sprehn <esprehn at chromium.org>  2012-12-12 15:33:18 PST ---
(From update of attachment 155722)
View in context: https://bugs.webkit.org/attachment.cgi?id=155722&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3185
> +    if (isInlineBlockOrInlineTable())

This permits :before and :after to be selection roots, was that intended?

>> Source/WebCore/rendering/RenderBlock.cpp:3189
>>          return false;
> 
> I've done some investigation and it appears that we should just remove this line. It was added in http://trac.webkit.org/changeset/12986 but I don't think we need it anymore.

Removing this line will make PseudoElement's capable of being selection roots. Note that now the code is if (!nonPseudoNode()) return; it'll also make the anonymous renderers inside them, and :first-letter, etc. all into selection roots.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.