[Webkit-unassigned] [Bug 104832] [BlackBerry] Ensure InRegionScrollableArea is valid before using.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 14:27:24 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=104832
Antonio Gomes <tonikitoo at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #179123|review? |review+, commit-queue-
Flag| |
--- Comment #5 from Antonio Gomes <tonikitoo at webkit.org> 2012-12-12 14:29:47 PST ---
(From update of attachment 179123)
View in context: https://bugs.webkit.org/attachment.cgi?id=179123&action=review
Please reupload with "Reviewed by antonio Gomes" and just request cq to land it.
r+, some nits though.
> Source/WebKit/blackberry/Api/InRegionScroller.cpp:420
> +bool InRegionScrollerPrivate::isValidScrollableLayerWebKitThread(WebCore::LayerWebKitThread* layerWebKitThread) const
WebCore:: is needed?
> Source/WebKit/blackberry/Api/InRegionScroller.cpp:428
> + for (unsigned i = 0; i < m_activeInRegionScrollableAreas.size(); i++)
> + if (static_cast<InRegionScrollableArea*>(m_activeInRegionScrollableAreas[i])->cachedScrollableLayer() == layerWebKitThread)
> + return true;
> +
for need {}
++i is preferred.
> Source/WebKit/blackberry/Api/InRegionScroller.cpp:432
> +bool InRegionScrollerPrivate::isValidScrollableNode(WebCore::Node* node) const
WebCore is needed?
> Source/WebKit/blackberry/Api/InRegionScroller.cpp:439
> + for (unsigned i = 0; i < m_activeInRegionScrollableAreas.size(); i++)
> + if (static_cast<InRegionScrollableArea*>(m_activeInRegionScrollableAreas[i])->cachedScrollableNode() == node)
> + return true;
ditto
++i is preferred.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list