[Webkit-unassigned] [Bug 104832] [BlackBerry] Ensure InRegionScrollableArea is valid before using.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104832





--- Comment #3 from Mike Lattanzio <mlattanzio at rim.com>  2012-12-12 13:48:01 PST ---
(In reply to comment #2)
> (From update of attachment 179099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179099&action=review
> 
> > Source/WebKit/blackberry/Api/InRegionScroller.cpp:420
> > +bool InRegionScrollerPrivate::isValidScrollableLayerWebKitThread(WebCore::LayerWebKitThread* layerWebKitThread)
> 
> const
> 
> > Source/WebKit/blackberry/Api/InRegionScroller.cpp:432
> > +bool InRegionScrollerPrivate::isValidScrollableNode(WebCore::Node* node)
> 
> const
>

Fixing those. Good eye.

> > Source/WebKit/blackberry/Api/InRegionScroller.cpp:437
> > +    for (unsigned i = 0; i < m_activeInRegionScrollableAreas.size(); i++)
> 
> IIRC calculateActiveAndShrinkCachedScrollableAreas shrink this vector. Does it need to be a for loop?

I think so. That shrinking is performed after we cast and use the layer, but we need to know if the layer still exists first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.