[Webkit-unassigned] [Bug 104807] Adds support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104807





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2012-12-12 11:16:45 PST ---
(In reply to comment #4)
> (From update of attachment 179038 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179038&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2029
> > +    speculationCheck(Uncountable, JSValueRegs(), NoNode, m_jit.branch32(MacroAssembler::AboveOrEqual, propertyReg, TrustedImm32(0x100)));
> 
> I know that the other string intrinsically do this as well but I would rather we not perpetuate it. Your patch could easily be a huge regression if someone does a Unicode fromcharcodeat that dominates a look. Please switch this to a slow path invocation.

*that dominates a loop. 

-F

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.