[Webkit-unassigned] [Bug 104807] Adds support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104807


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179038|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Oliver Hunt <oliver at apple.com>  2012-12-12 11:09:23 PST ---
(From update of attachment 179038)
View in context: https://bugs.webkit.org/attachment.cgi?id=179038&action=review

Code looks good to me, but you need to make sure you have a real change log.  Once you've got that re-upload and i'll re-review and land.

> Source/JavaScriptCore/ChangeLog:8
> +        Need a short description (OOPS!).
> +        https://bugs.webkit.org/show_bug.cgi?id=104807
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Alas you need a real change log.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.