[Webkit-unassigned] [Bug 104329] [EFL] Refactor duplicate code into EflInspectorUtilities

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104329





--- Comment #10 from Seokju Kwon <seokju.kwon at gmail.com>  2012-12-12 06:41:49 PST ---
(In reply to comment #8)
> (From update of attachment 178544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178544&action=review
> 
> >> Source/WebCore/platform/FileSystem.h:233
> >> +String getInspectorResourcePath();
> > 
> > I think *inspectorResourcePath* is better according to webkit coding style guideline
> > 
> > Precede setters with the word "set". Use bare words for getters. Setter and getter names should match the names of the variables being set/gotten.
> > Right:
> > void setCount(size_t); // sets m_count
> > size_t count(); // returns m_count
> > 
> > Wrong:
> > void setCount(size_t); // sets m_theCount
> > size_t getCount();
> 
> As we talked on irc, we need to find proper place for this utility function.

All done.
- Change function name.
- Move duplicate work into EflInspectorUtilities.

Please leave the comment, if you has a proper place for it.
If not, I will move it into EflInspectorUtilities for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.