[Webkit-unassigned] [Bug 99438] [WK2][WTR] Text input controller needs selectedRange implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 03:03:19 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=99438
--- Comment #21 from Mariusz Grzegorczyk <mariusz.g at samsung.com> 2012-12-12 03:05:41 PST ---
(In reply to comment #20)
> (From update of attachment 178994 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178994&action=review
>
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:1431
> > NSRange result = NSMakeRange(selectionStart, selectionLength);
> > - if (result.location == NSNotFound)
> > - LOG(TextInput, "selectedRange -> (NSNotFound, %u)", result.length);
> > + if (result.location == WTF::notFound)
> > + LOG(TextInput, "selectedRange -> (notFound, %u)", result.length);
>
> Don't we need to pass in NSNotFound to NSMakeRange?
In my opinion: no. NSMakeRange just fills structure with passed arguments. Because of common implementation getSelectedRange returns WTF::notFound instead of NSNotFound.
I suppose you are asking about following change:
...getSelectedRange(selectionStart, selectionLength);
+if (selectionStart == WTF::notFound)
+ selectionStart = NSNotFound;
if (result.location == NSNotFound)
LOG(TextInput, "selectedRange -> (NSNotFound, %u)", result.length);
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list