[Webkit-unassigned] [Bug 104613] [WK2] Fix memory sampler for ARM Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104613





--- Comment #5 from JungJik Lee <jungjik.lee at samsung.com>  2012-12-11 20:50:27 PST ---
(From update of attachment 178689)
View in context: https://bugs.webkit.org/attachment.cgi?id=178689&action=review

>>> Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp:-69
>>> -        if (ch == EOF || (isASCIISpace(ch) && index)) // Break on non-initial ASCII space.
>> 
>> I think you have the same issue in Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
> 
> NetscapePluginModuleX11.cpp looks good to me as the return value of fputc is assigned to a signed variable (int is signed).
> 
> int result;
> while ((result = fputc(*current, stdout)) == EOF && errno == EINTR) { }

I didn't think enough. Could we use feof(file) instead of ch == EOF?
if (feof(file) || ferror(file) || (isASCIISpace(ch) && index))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.