[Webkit-unassigned] [Bug 104354] IndexedDB: Don't use strings to represent serialized values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104354


Michael Pruett <michael at 68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178894|0                           |1
        is obsolete|                            |
 Attachment #178894|review?                     |
               Flag|                            |
 Attachment #178915|                            |review?
               Flag|                            |




--- Comment #10 from Michael Pruett <michael at 68k.org>  2012-12-11 16:36:41 PST ---
Created an attachment (id=178915)
 --> (https://bugs.webkit.org/attachment.cgi?id=178915&action=review)
Patch

I've added back WARN_UNUSED_RETURN which I erroneously removed from IDBBackingStore::putRecord(). I have also eliminated encodeIDBValue() and decodeIDBValue() and have replaced those with calls to Vector::appendVector() and Vector::appendRange(). I've also updated IDBBackingStore::Cursor::value() to return a const Vector<uint8_t>& rather than Vector<uint8_t>. I believe these changes should eliminate the extra memory copies introduced in my previous patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.