[Webkit-unassigned] [Bug 104627] Add an optional output to WebViewImpl::selectionBounds to query the order of selection anchor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104627





--- Comment #4 from Tien-Ren Chen <trchen at chromium.org>  2012-12-11 14:26:14 PST ---
(In reply to comment #3)
> (From update of attachment 178703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178703&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:2356
> >      if (!frame->selection()->selection().isBaseFirst())
> 
> I'm a little confused here.  It looks like anchor and focus are being swapped when isAnchorFirst is false.  Is that unnecessary if you are returning isAnchorFirst to the caller?  It seems a little odd to apply a transform on the WebKit side but also return the details of the transform.

It is used to return start and end but 66973 changed it to anchor and focus, and there is no way for us to query start and end from the embedder side.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.