[Webkit-unassigned] [Bug 104600] [Chromium] Ignore autocomplete=off in webkit code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104600





--- Comment #2 from Peter Beverloo <peter at chromium.org>  2012-12-11 10:36:28 PST ---
(From update of attachment 178640)
View in context: https://bugs.webkit.org/attachment.cgi?id=178640&action=review

A few drive-by nits :-)..

> Source/WebKit/chromium/ChangeLog:1
> +2012-12-10  Yue Zhang  <zysxqn at google.com>

nit: zysxqn at chromium.org

> Source/WebKit/chromium/ChangeLog:3
> +        Ignore autocomplete=off in webkit code

Since this only touches Chromium code (in Source/WebKit/chromium/), please prefix the subject with [Chromium]. This makes it easier to recognize for non-Chromium contributors. The "in webkit code" addition is rather redundant considering this would be committed to WebKit.

Furthermore, since this change only touches the findPasswordFormFields function, maybe "[Chromium] Always enable autocomplete for password fields" would be better?

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Adding some rationale here would be good. What is the reason the Chromium port would like to disable autocomplete for password fields?

As a FYI, any line that contains "OOPS!", *except* for the "Reviewed by" line, will prevent you from submitting this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.