[Webkit-unassigned] [Bug 103237] Performance gain for Animations using CSS 2D transforms while leveraging GPU accelerated compositing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103237





--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-12-10 17:03:57 PST ---
Attachment 178669 did not pass style-queue:

Source/WebCore/platform/graphics/transforms/TransformOperations.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:63:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:63:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:64:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:65:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:66:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:67:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperations.h:68:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/rendering/RenderLayerCompositor.cpp:1808:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:37:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:37:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:38:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:38:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:39:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:86:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:87:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:87:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:88:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:89:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:90:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:90:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:91:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:91:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:92:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:92:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:93:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:93:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:94:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:94:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:95:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:96:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:97:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:97:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:98:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:99:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:99:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:100:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:100:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:101:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:102:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:103:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:103:  Extra space after ( in if  [whitespace/parens] [5]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:104:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:104:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:105:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:106:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:107:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:108:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:109:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:110:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:111:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:112:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:112:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:113:  Tab found; better to use sFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
paces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:113:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:114:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:115:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:116:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/transforms/TransformOperation.h:117:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 62 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.