[Webkit-unassigned] [Bug 104573] [EFL][WK2] Layers are shifted vertically by 1-2 pixels in compositing/geometry tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104573





--- Comment #1 from Viatcheslav Ostapenko <ostap73 at gmail.com>  2012-12-10 14:32:56 PST ---
r101343 removed this code with comment:

-    // There seems to be some rounding error in cairo (or in how we
-    // use cairo) with some fonts, like DejaVu Sans Mono, which makes
-    // cairo report a height smaller than ascent + descent, which is
-    // wrong and confuses WebCore's layout system. Workaround this
-    // while we figure out what's going on.
-    float lineSpacing = font_extents.height;
-    if (lineSpacing < font_extents.ascent + font_extents.descent)
-        lineSpacing = font_extents.ascent + font_extents.descent;

It seems this exactly what happens here. Shouldn't we check that lineGap (in new code) is non-negative?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.