[Webkit-unassigned] [Bug 104427] WebViewClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 11:18:27 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104427





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-12-10 11:20:51 PST ---
(From update of attachment 178325)
View in context: https://bugs.webkit.org/attachment.cgi?id=178325&action=review

> Source/WebKit/chromium/public/WebViewClient.h:148
> +    enum EventStatus {

nit: It feels like this enum would be better at the top-level.  WebViewClient is already a big interface.

> Source/WebKit/chromium/public/WebViewClient.h:149
> +        EventStatusBubbledUp,

nit: Another name for EventStatusBubbledUp would be EventStatusUnprocessed or EventStatusNotProcessed, right?
Such a name might be easier to understand.  It was not obvious to me that "bubbled up" meant that WebKit
didn't handle the event.

Q: Are there cases where the event might get handled, but still propagate to another handler that would
then cancel further event propagation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list