[Webkit-unassigned] [Bug 104472] [Windows]ASSERTION failed in Windows: css3/css3-modsel-33.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104472





--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2012-12-10 11:12:44 PST ---
(From update of attachment 178402)
View in context: https://bugs.webkit.org/attachment.cgi?id=178402&action=review

I think this looks like a good change, but I wonder if things might be clearer if we didn't reuse the variable for two different purposes.

> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:429
> +    frameLoadDelegatePrivate = 0;

This seems like a good change, but would it be clearer if we used separate COMPtrs for the two possible cases? Maybe we should have each one declared within the scope of the DidFirstlayout and DidFirstVisuallyNonEmpty Layout?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.