[Webkit-unassigned] [Bug 104003] WebKit tests for the Qt API should include tests of CMake config files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104003


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177483|review?                     |review-
               Flag|                            |




--- Comment #1 from Simon Hausmann <hausmann at webkit.org>  2012-12-10 03:13:00 PST ---
(From update of attachment 177483)
Patch looks good in general, but please include a ChangeLog.

You can do this for example by calling

Tools/Scripts/webkit-patch prepare 104003

The number is the number of this bug, so that the ChangeLog will automatically include a reference to this bug.
After calling this command, open the ChangeLog changed files and complete the new entries. Afterwards you can post your patch automatically to bugzilla by using

Tools/Scripts/webkit-patch post

and you can pass --request-commit as parameter to the post command if you'd like to get the patch landed automatically using the commit queue. (you probably want this unless you are a committer yourself or you know somebody how is going to care of landing the change in SVN)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.