[Webkit-unassigned] [Bug 104483] AX: wrong Enabled states on a ListBox
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 10 03:06:27 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=104483
Alejandro Piñeiro <apinheiro at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #178417|0 |1
is obsolete| |
Attachment #178417|review?, commit-queue? |
Flag| |
Attachment #178504| |review?, commit-queue?
Flag| |
--- Comment #4 from Alejandro Piñeiro <apinheiro at igalia.com> 2012-12-10 03:08:52 PST ---
Created an attachment (id=178504)
--> (https://bugs.webkit.org/attachment.cgi?id=178504&action=review)
Fixes the bug
(In reply to comment #3)
> (From update of attachment 178417 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178417&action=review
>
> It bugs me a bit that we're checking for aria_disabledAttr in two methods, but I see a bunch of different implementations that would make a common implementation a bit tricky and less glamorous to get right.
> I think if we continue to provide custom isEnabled implementations we should think about refactoring a bit, but I think this is OK in current form
I agree.
> just a minor comment about the layout tests
>
> > LayoutTests/accessibility/listbox-enabled-states.html:35
> > + shouldBeTrue('accessibilityController.focusedElement.childAtIndex(4).isEnabled');
>
> you should also include the js-post test scripts so that we get the successfullyParsed messages
Done.
Note: I based this tests on a existing one, so the reasons I didn't notice this. Right now there are several tests that lack the js-post. Anyway not sure if a "cleaning task" it is worth or not.
>
> > Source/WebCore/ChangeLog:3
> > + Wrong Enabled states on a ListBox
>
> We should probably prefix the bug title with AX: *
> so that others know what this refers to
Done
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list