[Webkit-unassigned] [Bug 104279] [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104279





--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2012-12-09 13:57:19 PST ---
(In reply to comment #4)
> (From update of attachment 178047 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178047&action=review
> 
> > Tools/Scripts/check-for-inappropriate-macros-in-external-headers:43
> > +  full_path = File.join Dir.pwd, framework, $is_shallow_bundle ? "" : "Versions/A/", path
> 
> Can you use CONTENTS_FOLDER_PATH instead of the framework parameter and this?

Good idea. I'll take a look. The other Scripts/Tools/check-* scripts used this SHALLOW_BUNDLE approach, so if we can convert to a cleaner approach I'll update those as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.