[Webkit-unassigned] [Bug 104240] [CMake] Add CMake style checker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104240





--- Comment #9 from Eric Seidel <eric at webkit.org>  2012-12-07 21:14:30 PST ---
(From update of attachment 178313)
View in context: https://bugs.webkit.org/attachment.cgi?id=178313&action=review

> Tools/Scripts/webkitpy/style/checker.py:581
> +        elif ((file_extension == _CMAKE_FILE_EXTENSION) or os.path.basename(file_path) == 'CMakeLists.txt'):

Some day we should move all this code to use the webkitpy.common.system abstractions (like FileSystem) to make this code more easily unittestable.  (This is unrelated to your patch.)

> Tools/Scripts/webkitpy/style/checkers/cmake.py:29
> +import os
> +import re
> +import sys

os and sys seem unused?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.