[Webkit-unassigned] [Bug 98705] [EFL][WK2] Add Remote Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98705





--- Comment #16 from Seokju Kwon <seokju.kwon at samsung.com>  2012-12-07 19:28:41 PST ---
(In reply to comment #15)
> (From update of attachment 177992 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177992&action=review
> 
> > Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:53
> > +    String localPath = inspectorResourcePath() + ((path == "/") ? "/inspectorPageIndex.html" : path);
> 
> At least, it looks you can use ASCIILiteral("/inspectorPageIndex.html") instead of "/inspectorPageIndex.html".
> 
> > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:46
> > +
> 
> It would be good if you add a comment why *initialized* should be true.

All done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.