[Webkit-unassigned] [Bug 104146] Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104146





--- Comment #7 from egraether at chromium.org  2012-12-07 11:28:55 PST ---
(In reply to comment #5)

I updated the patch:

> (From update of attachment 177840 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review
> 
> > Source/WebCore/inspector/front-end/DOMAgent.js:777
> > +        WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility);
> 
> Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter.

done

> > Source/WebCore/inspector/front-end/treeoutline.js:377
> > +    else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code)
> 
> Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it.

I found a spot in ElementsTreeOutline.js that seemed to fit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.