[Webkit-unassigned] [Bug 104240] [CMake] Add CMake style checker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104240


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178187|review?                     |review-
               Flag|                            |




--- Comment #7 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-12-07 10:53:14 PST ---
(From update of attachment 178187)
View in context: https://bugs.webkit.org/attachment.cgi?id=178187&action=review

Almost there, but I think the patch itself should pass the style check; r- for that.

> Tools/Scripts/webkitpy/style/checkers/cmake_unittest_input.cmake:1
> +# This file is sample input for cmake_unittest.py and includes below problems:

It would be better to include the test input inside cmake_unittest.py and not as a separate file - not necessary as one big buffer but as a serious of unit tests like it is done for the other checkers (see for example changelog_unittest.py). This would also avoid the problem that your negative tests in the cmake_unittest*.cmake fail on the style check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.