[Webkit-unassigned] [Bug 104369] [GTK] Expose HitTestResult::scrollbar() condition in API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104369


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178221|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-12-07 08:29:47 PST ---
(From update of attachment 178221)
View in context: https://bugs.webkit.org/attachment.cgi?id=178221&action=review

Patch looks great, thanks! Setting r- just because it doesn't include unit tests. You can modify WebKitWebView/mouse-target test to check it. Use a form control containing scrollbars, because main scrollbars won't work due to bug #99591.

> Source/WebKit2/Shared/WebHitTestResult.h:55
> +        bool isOverScrollbar;

I would use isScrollbar.

> Source/WebKit2/Shared/WebHitTestResult.h:87
> +            , isOverScrollbar(hitTestResult.scrollbar())

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.