[Webkit-unassigned] [Bug 104146] Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104146


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177840|review?                     |review-
               Flag|                            |




--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2012-12-07 05:10:53 PST ---
(From update of attachment 177840)
View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:777
> +        WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility);

Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter.

> Source/WebCore/inspector/front-end/treeoutline.js:377
> +    else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code)

Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.