[Webkit-unassigned] [Bug 103342] [EFL][WK2] Add ewk_settings APIs for text autosizing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103342





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-06 18:18:47 PST ---
(From update of attachment 176138)
View in context: https://bugs.webkit.org/attachment.cgi?id=176138&action=review

>>>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:354
>>>> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
>>> 
>>> I think we don't need to keep this line when disabling TEXT_AUTOSIZING
>> 
>> The line is correct and people could give a null pointer.
>> 
>> I say leave it
> 
> Ok, I don't mind this. Jaehun, please fix I pointed out.

I missed one thing. EFL port has used below line. To be compliant with existing implementation, I prefer to use below style. My first comment meant this. 

#if ENABLE(TEXT_AUTOSIZING)
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
   settings->preferences()->setTextAutosizingEnabled(enable);

   return true;
#else
   UNUSED_PARAM(enable);
   return false;
#endif
}

For example,

Eina_Bool ewk_settings_fullscreen_enabled_get(const Ewk_Settings* settings)
{
#if ENABLE(FULLSCREEN_API)
    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
    return settings->preferences()->fullScreenEnabled();
#else
    return false;
#endif
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.