[Webkit-unassigned] [Bug 103342] [EFL][WK2] Add ewk_settings APIs for text autosizing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103342





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-06 17:59:22 PST ---
(From update of attachment 176138)
View in context: https://bugs.webkit.org/attachment.cgi?id=176138&action=review

> Source/WebKit2/ChangeLog:9
> +        Text autosizing is disabled by default.

I think this API is not meaningless if text autosizing is disabled.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:354
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);

I think we don't need to keep this line when disabling TEXT_AUTOSIZING

> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:368
> +#if ENABLE(TEXT_AUTOSIZING)

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:370
> +#else

Missing UNUSED_PARAM

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.