[Webkit-unassigned] [Bug 104191] Implement matching cue by the class name with ::cue pseudo element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 15:26:07 PST 2012


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
 Attachment #177912|review?                     |review-
               Flag|                            |

--- Comment #7 from Antti Koivisto <koivisto at iki.fi>  2012-12-06 15:28:33 PST ---
(From update of attachment 177912)
View in context: https://bugs.webkit.org/attachment.cgi?id=177912&action=review

> Source/WebCore/css/CSSParser.cpp:10104
> +        // Don't set the tag for the PseudoCue element because the matching will not work when the tags are being compared.
> +        if (!(specifiers->pseudoType() == CSSSelector::PseudoCue))
> +#endif
> +            specifiers->setTag(tag);

I don't quite understand this. The comment is not very helpful.

> Source/WebCore/css/SelectorChecker.cpp:1160
> +        subContext.isMatchingCueNodes = true;

I don't see you ever reading this bit. Why does it exist?

> Source/WebCore/dom/Element.cpp:2482
> +    if (other.isWebVTTNode())
> +        setIsWebVTTNode(true);
> +#endif
>      cloneAttributesFromElement(other);
>      copyNonAttributePropertiesFromElement(other);

I think this can be handled in a cleaner way. See the comment below.

> Source/WebCore/html/track/WebVTTParser.cpp:367
>              child = HTMLElement::create(qTag, document);
>          if (child) {
> +            child->setIsWebVTTNode(true);

I think you will want to add new private HTMLElement subclass (WebVTTElement or similar) and build the tree out of those instead of generic HTMLElements. That class will have virtual copyNonAttributePropertiesFromElement() function that will copy the isWebVTTNode bit and any other metadata you might want. Or maybe just make isWebVTTNode itself virtual, it is not called much I think.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list