[Webkit-unassigned] [Bug 104196] Adding New WebInputEvent type for IME events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104196





--- Comment #12 from Min Qin <qinmin at chromium.org>  2012-12-06 11:34:57 PST ---
(In reply to comment #8)
> (From update of attachment 177901 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177901&action=review
> 
> > Source/WebKit/chromium/public/WebInputEvent.h:313
> > +    // Caps on string lengths so we can make them static arrays and keep
> > +    // them PODs.
> > +    static const size_t textLengthCap = 400;
> > +
> > +    // |text| is the text that needs to be composed, committed, or replaced.
> > +    WebUChar text[textLengthCap];
> 
> WebInputEvents are assumed to be POD and to be *cheap* to copy.  Making some be 800 bytes long seems contrary to this goal.


I think we can make WebImeEvents relatively small by adding the text to ViewMsg_HandleInputEvent. 
The ViewMsg_HandleInputEvent containing a WebImeEvent may not be passed to the compositor thread, but they will stay in the message queue in input_event_filter. And when the queue is empty or a previous event get acked, we will pass all the following WebImeEvent to the render thread.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.