[Webkit-unassigned] [Bug 104035] Support text-orientation: sideways-right (and sideways when it maps to sideways-right)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104035


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #12 from mitz at webkit.org <mitz at webkit.org>  2012-12-06 10:16:13 PST ---
(In reply to comment #11)
> (From update of attachment 177642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177642&action=review
> 
> > Source/WebCore/rendering/style/RenderStyle.h:1801
> > +    if (compareEqual(rareInheritedData->m_textOrientation, textOrientation))
> 
> What is the compareEqual function? I never heard of that before.

It’s a function template that casts the right hand side to the left hand side’s type (we used unsigned for many of the StyleRareInheritedData data members, for reasons that involve MSVC if I remember correctly). It’s used in the SET_VAR macro, and the above use is similar to an expansion of that macro.

Anyway, the reason I used it here was that I was following a pattern.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.