[Webkit-unassigned] [Bug 104124] [Qt] Fix the build if the path contains "~" character

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 04:33:22 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104124





--- Comment #7 from Csaba Osztrogonac <ossy at webkit.org>  2012-12-06 04:35:49 PST ---
(In reply to comment #6)
> (In reply to comment #3)
> > I have a workaround for this bug: removing "CONFIG += object_parallel_to_source"
> 
> That's replacing one bug with another, the config is there for a reason. We should find the root cause and fix it.

To make it clear: the reason for introducing this object_parallel_to_source
config was to make "GNUmake gcc_MD_depends" configs resistent against moving sources - http://trac.webkit.org/changeset/102452 (and avoiding possible name
clashes inside WebCore/JavascriptCore/WebKit/WebKit2)

I disagree if the workaround is replacing one bug with another one. The build
is totally broken now if the directory contains a tilde character. Removing
this config fixes the build for non-incremental builds. I didn't propose to
remove it, as I mentioned it is only a workaround for this bug. I agree that the object_parallel_to_source config can be useful for developers to avoid
incremental build issues and to reduce the likelihood of different problems
because of clashing filenames.

Of course we should fix the bugs instead of working around them. 
I think we need to following fixes:
- make qmake not to use buggy deep paths for "object_parallel_to_source" config
- make qmake escape all ~ in object/source name not to confuse make/sh/bash/...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list