[Webkit-unassigned] [Bug 104103] Implement add64 for ARM traditional assembler after r136601

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104103


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177742|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Zoltan Herczeg <zherczeg at webkit.org>  2012-12-06 04:02:06 PST ---
(From update of attachment 177742)
View in context: https://bugs.webkit.org/attachment.cgi?id=177742&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:905
> +        if (imm.m_value <= 0xff)
> +            m_assembler.adds(ARMRegisters::S0, ARMRegisters::S0, ARMAssembler::getOp2Byte(imm.m_value));
> +        else {
> +            m_assembler.adds(ARMRegisters::S0, ARMRegisters::S0, m_assembler.getImm(imm.m_value, ARMRegisters::S1));
> +            move(TrustedImmPtr(address.m_ptr), ARMRegisters::S1);
> +        }

This is not how we do at the moment. This should be a simple:

m_assembler.adds(dest, dest, m_assembler.getImm(imm.m_value, ARMRegisters::S0));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.