[Webkit-unassigned] [Bug 104196] Adding New WebInputEvent type for IME events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104196


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177901|review?                     |review-
               Flag|                            |




--- Comment #8 from James Robinson <jamesr at chromium.org>  2012-12-05 21:55:16 PST ---
(From update of attachment 177901)
View in context: https://bugs.webkit.org/attachment.cgi?id=177901&action=review

> Source/WebKit/chromium/public/WebInputEvent.h:313
> +    // Caps on string lengths so we can make them static arrays and keep
> +    // them PODs.
> +    static const size_t textLengthCap = 400;
> +
> +    // |text| is the text that needs to be composed, committed, or replaced.
> +    WebUChar text[textLengthCap];

WebInputEvents are assumed to be POD and to be *cheap* to copy.  Making some be 800 bytes long seems contrary to this goal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.