[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 5 00:12:09 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=102853
--- Comment #17 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> 2012-12-05 00:14:33 PST ---
(From update of attachment 177678)
View in context: https://bugs.webkit.org/attachment.cgi?id=177678&action=review
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:43
> + : m_applicationCacheManager(applicationCacheManager)
assert?
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:54
> + const size_t length = WKArrayGetSize(origins);
const should not be used with local vars, due to coding style.
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:80
> + delete webApplicationCacheContext;
if you used own_ptr for 'webApplicationCacheContext' with adoption, manual delete would be avoided
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager_private.h:38
> +struct _Ewk_Application_Cache_Origins_Async_Get_Context {
Do we have to use "_" for private object names?
> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager_private.h:39
> + const Ewk_Application_Cache_Manager* manager;
isn't it EwkApplicationCacheManager ?
> Source/WebKit2/UIProcess/API/efl/ewk_context_private.h:58
> + inline EwkApplicationCacheManager* applicationCacheManager() const { return m_applicationCacheManager.get(); }
inline is unneeded here, as function is defined in header.
And again const member returns mutable pointer :(
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list