[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853





--- Comment #15 from Jiyeon Kim <jiyeon0402.kim at samsung.com>  2012-12-04 23:05:49 PST ---
(In reply to comment #12)
> (From update of attachment 177636 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177636&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:34
> > +    unsigned getPort() const;
> 
> strange, is port() correct for coding style?
> 
Yes, I'll fix.
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:31
> > +#include "ewk_security_origin_private.h"
> 
> private.h is required?
> 
I'll change ewk_security_origin.h to ewk_security_origin_private.h
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:33
> > +#include <Ecore.h>
> 
> I am not sure whether we should add EWebKit2.h and Ecore.h
> In other test cases, it was omitted because EWK2UnitTestBase.h include.
> 
I'll remove.
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:62
> > +const char* applicationCacheHtml =
> 
> Should it be globa?
> If then, please add static.
> 
> And const char XXX[] = is prefered.
> 
I'll fix.
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:126
> > +        eina_strbuf_append_printf(body, applicationCacheHtml, 0);
> > +        const size_t bodyLength = eina_strbuf_length_get(body);
> > +        soup_message_body_append(message->response_body, SOUP_MEMORY_TAKE, eina_strbuf_string_steal(body), bodyLength);
> > +    } else if (!strcmp(path, applicationCacheManifestFile)) {
> > +        eina_strbuf_append_printf(body, applicationCacheManifest, 0);
> > +        const size_t bodyLength = eina_strbuf_length_get(body);
> > +        soup_message_body_append(message->response_body, SOUP_MEMORY_TAKE, eina_strbuf_string_steal(body), bodyLength);
> > +    } else if (!strcmp(path, applicationCacheCssFile)) {
> > +        eina_strbuf_append_printf(body, applicationCacheCss, 0);
> > +        const size_t bodyLength = eina_strbuf_length_get(body);
> > +        soup_message_body_append(message->response_body, SOUP_MEMORY_TAKE, eina_strbuf_string_steal(body), bodyLength);
> > +    } else
> > +        soup_message_set_status(message, SOUP_STATUS_NOT_FOUND);
> 
> How about reducing the duplication?
I'll reduce the duplication.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.