[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853





--- Comment #13 from Jiyeon Kim <jiyeon0402.kim at samsung.com>  2012-12-04 21:13:27 PST ---
(In reply to comment #11)
> (From update of attachment 177636 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177636&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:78
> > +        ewk_object_unref(static_cast<Ewk_Security_Origin*>(item));
> 
> I don't understand why you delete Ewk_Security_Origin via ewk_object_unref. AFAIK, ewk_object_unref is meaningful when item is based on EwkObject.
Ewk_Security_Origin also based on EwkObject.
But I'll change ewk_object_unref(static_cast<Ewk_Object*>(item));
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager_private.h:38
> > +struct Ewk_Application_Cache_Origins_Async_Get_Context {
> 
> Why do you use *_Get_* in struct name ? I don't know what does *Get* means here. Is Ewk_Application_Cache_Origins_Async_Context enough ?
> 
> Beside this struct is for internal usage, right ? If so, I prefer not to use _ in struct name.
This struct is for get application cache origins Callback. So I added *Get*.
And other struct name also "Get_Policy_Async_Data", "Get_Hostnames_Async_Data
".
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:154
> > + * @param context context object to query.
> 
> We don't use . at the end of line in @param field.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:156
> > + * @return Ewk_Application_Cache_Manager object instance or @c NULL in case of failure.
> 
> ditto.
> 
> 
 Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:78
> > +const char* applicationCacheCss =   "output { font:2em sans-serif; }";
> 
> s/=   /= /g
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:138
> > +
> 
> Unneeded line.
I'll fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.