[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853





--- Comment #11 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-04 18:53:20 PST ---
(From update of attachment 177636)
View in context: https://bugs.webkit.org/attachment.cgi?id=177636&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:78
> +        ewk_object_unref(static_cast<Ewk_Security_Origin*>(item));

I don't understand why you delete Ewk_Security_Origin via ewk_object_unref. AFAIK, ewk_object_unref is meaningful when item is based on EwkObject.

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager_private.h:38
> +struct Ewk_Application_Cache_Origins_Async_Get_Context {

Why do you use *_Get_* in struct name ? I don't know what does *Get* means here. Is Ewk_Application_Cache_Origins_Async_Context enough ?

Beside this struct is for internal usage, right ? If so, I prefer not to use _ in struct name.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:154
> + * @param context context object to query.

We don't use . at the end of line in @param field.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:156
> + * @return Ewk_Application_Cache_Manager object instance or @c NULL in case of failure.

ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:78
> +const char* applicationCacheCss =   "output { font:2em sans-serif; }";

s/=   /= /g

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:138
> +

Unneeded line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.