[Webkit-unassigned] [Bug 104043] Implement general ::cue pseudo element for the <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104043





--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2012-12-04 17:56:00 PST ---
(From update of attachment 177621)
View in context: https://bugs.webkit.org/attachment.cgi?id=177621&action=review

Looks good except for the ChangeLog.

> Source/WebCore/ChangeLog:10
> +2012-12-04  Dima Gorbik  <dgorbik at apple.com>
> +
> +        Implement general ::cue pseudo element for the <video>
> +        https://bugs.webkit.org/show_bug.cgi?id=104043
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Implemented the ::cue pseudo element to be able to style all WebVTT cues.
> +
> +        Test: media/track/track-css-all-cues.html

Please make the ChangeLog bit more descriptive. A pointer to the relevant standard section would be good. What part is exactly implemented by this patch and what is still left to implement? What is the plan going forward?

>> Source/WebCore/ChangeLog:19
>> +        * html/shadow/MediaControlElements.cpp:
>> +        (WebCore):
>> +        (WebCore::MediaControlTextTrackContainerElement::createSubtrees):
>> +        (WebCore::MediaControlTextTrackContainerElement::updateDisplay):
>> +        * html/shadow/MediaControlElements.h:
>> +        (MediaControlTextTrackContainerElement):
>> +        * html/shadow/MediaControlRootElement.cpp:
>> +        (WebCore::MediaControlRootElement::createTextTrackDisplay):
> 
> Ditto.

Some implementation comments here would be good too. Why is cueContainer subtree needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.