[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513





--- Comment #52 from Antoine Quint <graouts at apple.com>  2012-12-04 14:33:55 PST ---
(In reply to comment #48)
> (From update of attachment 177472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177472&action=review
> 
> > LayoutTests/inspector-protocol/layer-tree.html:92
> > +            parameters: { "layerId": lastId },
> 
> No spaces inside {}.

Fixed in 7th patch.

> > LayoutTests/inspector-protocol/layer-tree.html:103
> > +            parameters: { "nodeId": id },
> 
> No spaces inside {}.

Fixed in 7th patch.

> >> LayoutTests/inspector-protocol/layer-tree.html:146
> >> +        function recurse (layer) {
> > 
> > recurse(layer)
> 
> The { should also be on a new line.

Fixed in 7th patch.

> >> LayoutTests/inspector-protocol/layer-tree.html:170
> >> +            return (key === "layerId") ? undefined : value;
> > 
> > style: please drop redundant parenthesis
> > we typically dump typeof value instead of value if value is non-stable -- this occasionally helps to catch regressions for values that are missing or of a wrong type.
> 
> Should memory be replaced too? I don't think it will stay constant and might lead to flakiness. Unless it is always constant based on the width and height.

Memory should be based purely on width and height and not flaky. I've preserved it in the updated patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.