[Webkit-unassigned] [Bug 103510] Reduce the children repaints when moved multiple times during the layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 10:49:08 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103510





--- Comment #18 from Ojan Vafai <ojan at chromium.org>  2012-12-04 10:51:35 PST ---
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:338
> > +    ChildrenFrameRects childrenOldRects;
> > +    appendChildrenFrameRects(childrenOldRects);
> >      layoutFlexItems(*m_orderIterator, lineContexts);
> 
> It’s strange that layoutFlexItems receives the iterator as an argument, but appendChildrenFrameRects and repaintChildrenDuringLayoutIfMoved both get the iterator directly from the data member. The three functions should do this consistently.

We should change layoutFlexItems, et al, to always use the member. It didn't used to be a member and we just never did the cleanup to stop passing it as an argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list