[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103513


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177472|review?                     |review-
               Flag|                            |




--- Comment #48 from Timothy Hatcher <timothy at apple.com>  2012-12-04 10:13:00 PST ---
(From update of attachment 177472)
View in context: https://bugs.webkit.org/attachment.cgi?id=177472&action=review

Post a version with some of these tweaks, especially the dumping typeof instead of dropping the replaced properties, and I'll r+ it.

> LayoutTests/inspector-protocol/layer-tree.html:92
> +            parameters: { "layerId": lastId },

No spaces inside {}.

> LayoutTests/inspector-protocol/layer-tree.html:103
> +            parameters: { "nodeId": id },

No spaces inside {}.

>> LayoutTests/inspector-protocol/layer-tree.html:146
>> +        function recurse (layer) {
> 
> recurse(layer)

The { should also be on a new line.

>> LayoutTests/inspector-protocol/layer-tree.html:170
>> +            return (key === "layerId") ? undefined : value;
> 
> style: please drop redundant parenthesis
> we typically dump typeof value instead of value if value is non-stable -- this occasionally helps to catch regressions for values that are missing or of a wrong type.

Should memory be replaced too? I don't think it will stay constant and might lead to flakiness. Unless it is always constant based on the width and height.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.